Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right executor for EndTransactionProcessor #4044

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented Mar 28, 2022

Make sure set the target branch to develop

What is the purpose of the change

It should use endTransactionExecutor for EndTransactionProcessor. So fix it in this pr.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@cserwen
Copy link
Member Author

cserwen commented Mar 28, 2022

@RongtongJin Can you help me to review this pr?

@RongtongJin
Copy link
Contributor

Good catch!

@RongtongJin RongtongJin merged commit d8119af into apache:5.0.0-beta Mar 28, 2022
@RongtongJin
Copy link
Contributor

Merged

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 47.222% when pulling 9cc2a5b on cserwen:fix-executor into 3f28f5f on apache:5.0.0-beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 47.222% when pulling 9cc2a5b on cserwen:fix-executor into 3f28f5f on apache:5.0.0-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants