-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish switching logic and auto switch ha code #4406
Polish switching logic and auto switch ha code #4406
Conversation
@hzh0425 PTAL~ |
Maybe something wrong when change the logic |
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta-dledger-controller #4406 +/- ##
================================================================
Coverage 43.30% 43.30%
Complexity 6338 6338
================================================================
Files 839 839
Lines 59637 59637
Branches 8130 8131 +1
================================================================
+ Hits 25824 25826 +2
+ Misses 30469 30462 -7
- Partials 3344 3349 +5
Continue to review full report at Codecov.
|
@@ -100,9 +100,6 @@ public AutoSwitchHAService() { | |||
|
|||
this.defaultMessageStore.recoverTopicQueueTable(); | |||
|
|||
final HashSet<String> newSyncStateSet = new HashSet<>(); | |||
newSyncStateSet.add(this.localAddress); | |||
setSyncStateSet(newSyncStateSet); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在 controller 里的逻辑是, 新选举出来的 master, syncStateSet 只有该 Master, 这里是为了应和 controller 里的逻辑.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make sure set the target branch to
develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.