Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4481]lock method invoke should before try scope #4482

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Inuyasha-Monster
Copy link
Contributor

@Inuyasha-Monster Inuyasha-Monster commented Jun 20, 2022

Make sure set the target branch to develop

What is the purpose of the change

org.apache.rocketmq.client.impl.consumer.ConsumeMessageOrderlyService
image
as the title, the similar pr #4113

Brief changelog

Details in the pr that refers to this issue.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #4482 (1430c15) into develop (32733e7) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4482      +/-   ##
=============================================
- Coverage      48.14%   48.07%   -0.08%     
+ Complexity      5125     5115      -10     
=============================================
  Files            649      649              
  Lines          43021    43021              
  Branches        5625     5625              
=============================================
- Hits           20713    20681      -32     
- Misses         19802    19831      +29     
- Partials        2506     2509       +3     
Impacted Files Coverage Δ
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.64% <100.00%> (-0.36%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 47.82% <0.00%> (-4.35%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.84% <0.00%> (-3.00%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 80.97% <0.00%> (-1.47%) ⬇️
...client/consumer/store/RemoteBrokerOffsetStore.java 70.27% <0.00%> (-0.91%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 71.35% <0.00%> (-0.51%) ⬇️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 57.92% <0.00%> (-0.50%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.88% <0.00%> (-0.47%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 50.83% <0.00%> (-0.46%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32733e7...1430c15. Read the comment docs.

hzh0425
hzh0425 previously approved these changes Jun 20, 2022
@coveralls
Copy link

coveralls commented Jun 21, 2022

Coverage Status

Coverage increased (+0.08%) to 47.624% when pulling 3e534b7 on djl394922860:develop into b136f9b on apache:develop.

Oliverwqcwrw
Oliverwqcwrw previously approved these changes Jun 21, 2022
Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk dismissed stale reviews from Oliverwqcwrw and hzh0425 via 3e534b7 June 8, 2023 03:46
@leizhiyuan
Copy link
Contributor

Can you resolve the conflict, then re-review and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants