New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4481]lock method invoke should before try scope #4482
base: develop
Are you sure you want to change the base?
Conversation
e21f48c
to
3edac25
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4482 +/- ##
=============================================
- Coverage 48.14% 48.07% -0.08%
+ Complexity 5125 5115 -10
=============================================
Files 649 649
Lines 43021 43021
Branches 5625 5625
=============================================
- Hits 20713 20681 -32
- Misses 19802 19831 +29
- Partials 2506 2509 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you resolve the conflict, then re-review and merge it? |
Make sure set the target branch to
develop
What is the purpose of the change
org.apache.rocketmq.client.impl.consumer.ConsumeMessageOrderlyService
as the title, the similar pr #4113
Brief changelog
Details in the pr that refers to this issue.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.