Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4461] Support to change the logger level dynamically #4547

Merged

Conversation

Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4461

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #4547 (cbd9acb) into develop (493e52b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4547      +/-   ##
=============================================
- Coverage      48.17%   48.13%   -0.05%     
+ Complexity      5129     5125       -4     
=============================================
  Files            649      649              
  Lines          43045    43045              
  Branches        5630     5630              
=============================================
- Hits           20737    20719      -18     
- Misses         19801    19816      +15     
- Partials        2507     2510       +3     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 44.77% <0.00%> (-7.47%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 70.84% <0.00%> (-0.51%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 76.65% <0.00%> (+0.11%) ⬆️
...client/consumer/store/RemoteBrokerOffsetStore.java 71.17% <0.00%> (+0.90%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493e52b...cbd9acb. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 2, 2022

Coverage Status

Coverage decreased (-0.2%) to 51.964% when pulling cbd9acb on Oliverwqcwrw:develop-dynamic-change-level-16 into 493e52b on apache:develop.

Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's too frequent to check log configuration every 3s, maybe 30s or 1min would be a more appropriate interval.

@Oliverwqcwrw
Copy link
Member Author

Ok , I will adjust to 30s

@duhenglucky duhenglucky merged commit 8a48445 into apache:develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can‘t change the logger level dynamicly
6 participants