Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of abnormal statistics under Bcq #4567

Merged

Conversation

guyinyou
Copy link
Contributor

@guyinyou guyinyou commented Jul 7, 2022

Make sure set the target branch to develop

What is the purpose of the change

#4566

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 47.455% when pulling 5060707 on guyinyou:5.0.0-beta-auto-batch into 2569041 on apache:5.0.0-beta-auto-batch.

@codecov-commenter
Copy link

Codecov Report

Merging #4567 (5060707) into 5.0.0-beta-auto-batch (2569041) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@                     Coverage Diff                     @@
##             5.0.0-beta-auto-batch    #4567      +/-   ##
===========================================================
+ Coverage                    43.21%   43.25%   +0.03%     
- Complexity                    6077     6087      +10     
===========================================================
  Files                          802      802              
  Lines                        57463    57463              
  Branches                      7862     7862              
===========================================================
+ Hits                         24833    24855      +22     
+ Misses                       29365    29345      -20     
+ Partials                      3265     3263       -2     
Impacted Files Coverage Δ
...main/java/org/apache/rocketmq/store/CommitLog.java 67.39% <100.00%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 52.60% <100.00%> (ø)
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 73.07% <0.00%> (-7.70%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...va/org/apache/rocketmq/store/util/PerfCounter.java 64.92% <0.00%> (-1.05%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 48.61% <0.00%> (-0.56%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 67.92% <0.00%> (-0.35%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.71% <0.00%> (+0.31%) ⬆️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.99% <0.00%> (+0.36%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.71% <0.00%> (+0.49%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2569041...5060707. Read the comment docs.

@RongtongJin RongtongJin merged commit 60c1823 into apache:5.0.0-beta-auto-batch Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants