New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4725] Optimize the CK/ACK 's invisibleTime in POP consumption mode. #4753
Conversation
@xdkxlk Please help review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@odbozhou You are pending on this PR, please help review and let's merge this PR ASAP. |
@GenerousMan It seems that some UT failed Results : |
Codecov Report
@@ Coverage Diff @@
## develop #4753 +/- ##
=============================================
- Coverage 45.05% 44.90% -0.15%
+ Complexity 7629 7604 -25
=============================================
Files 978 977 -1
Lines 67953 67955 +2
Branches 8982 8982
=============================================
- Hits 30614 30514 -100
- Misses 33570 33651 +81
- Partials 3769 3790 +21
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Make sure set the target branch to
develop
What is the purpose of the change
Replace scheduled message in POP with timer message.
In the current POP consumption mode, the InvisibleTime implementation of the CK/ACK message relies on the scheduled message. However, because of the precision limitation of the scheduled message, some CK/ACK messages may work not as expected. Since the completion of RIP-43, rocketmq can already support timing messages with arbitrary delay. Therefore, using this feature can optimize the POP consumption process.
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.