Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4785] Enable misspell check GitHub Action #4786

Merged
merged 2 commits into from Aug 8, 2022

Conversation

aaron-ai
Copy link
Member

@aaron-ai aaron-ai commented Aug 4, 2022

Fixes #4785

@aaron-ai aaron-ai changed the title Enable misspell check GitHub Action [ISSUE # 4785] Enable misspell check GitHub Action Aug 4, 2022
@aaron-ai aaron-ai changed the title [ISSUE # 4785] Enable misspell check GitHub Action [ISSUE #4785] Enable misspell check GitHub Action Aug 4, 2022
Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #4786 (0ca367a) into develop (c506036) will decrease coverage by 0.05%.
The diff coverage is 31.81%.

@@              Coverage Diff              @@
##             develop    #4786      +/-   ##
=============================================
- Coverage      45.07%   45.02%   -0.06%     
+ Complexity      7617     7607      -10     
=============================================
  Files            976      976              
  Lines          67808    67815       +7     
  Branches        8963     8963              
=============================================
- Hits           30564    30532      -32     
- Misses         33475    33512      +37     
- Partials        3769     3771       +2     
Impacted Files Coverage Δ
...ocketmq/broker/processor/AdminBrokerProcessor.java 26.57% <ø> (ø)
...apache/rocketmq/client/trace/TraceDataEncoder.java 69.73% <ø> (ø)
.../apache/rocketmq/client/trace/TraceDispatcher.java 100.00% <ø> (ø)
...pache/rocketmq/client/trace/TraceTransferBean.java 75.00% <ø> (ø)
...apache/rocketmq/common/message/MessageDecoder.java 61.04% <ø> (ø)
...tmq/common/statistics/StatisticsItemFormatter.java 0.00% <0.00%> (ø)
...stics/StatisticsItemScheduledIncrementPrinter.java 0.00% <0.00%> (ø)
...mon/statistics/StatisticsItemScheduledPrinter.java 0.00% <ø> (ø)
.../apache/rocketmq/common/utils/ServiceProvider.java 0.00% <0.00%> (ø)
.../apache/rocketmq/filter/parser/SelectorParser.java 40.11% <ø> (ø)
... and 31 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 49.12% when pulling 0ca367a on aaron-ai:feature/fix_typo into 273f274 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 49.12% when pulling 0ca367a on aaron-ai:feature/fix_typo into 273f274 on apache:develop.

@duhenglucky duhenglucky merged commit 61b14c3 into apache:develop Aug 8, 2022
@duhenglucky duhenglucky added this to the 5.0.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable misspell check GitHub Action
7 participants