Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4792] Add getControllerConfig and updateControllerConfig command for admin CLI #4793

Merged
merged 1 commit into from Aug 7, 2022

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Add getControllerConfig and updateControllerConfig command for admin CLI

Brief changelog

Add getControllerConfig and updateControllerConfig command for admin CLI

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #4793 (09e328a) into develop (c506036) will decrease coverage by 0.03%.
The diff coverage is 4.00%.

@@              Coverage Diff              @@
##             develop    #4793      +/-   ##
=============================================
- Coverage      45.07%   45.03%   -0.04%     
- Complexity      7617     7639      +22     
=============================================
  Files            976      978       +2     
  Lines          67808    67952     +144     
  Branches        8963     8982      +19     
=============================================
+ Hits           30564    30602      +38     
- Misses         33475    33582     +107     
+ Partials        3769     3768       -1     
Impacted Files Coverage Δ
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 23.65% <0.00%> (-0.56%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 47.44% <ø> (ø)
...g/apache/rocketmq/common/protocol/RequestCode.java 0.00% <ø> (ø)
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 32.16% <0.00%> (-0.58%) ⬇️
.../apache/rocketmq/tools/command/MQAdminStartup.java 0.00% <0.00%> (ø)
...tools/command/broker/GetBrokerEpochSubCommand.java 0.00% <0.00%> (ø)
...mand/controller/GetControllerConfigSubCommand.java 0.00% <0.00%> (ø)
...nd/controller/GetControllerMetaDataSubCommand.java 0.00% <0.00%> (ø)
...d/controller/UpdateControllerConfigSubCommand.java 0.00% <0.00%> (ø)
...ntroller/processor/ControllerRequestProcessor.java 26.19% <6.81%> (-20.62%) ⬇️
... and 32 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 49.158% when pulling 09e328a on RongtongJin:add-command into 034d738 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 49.158% when pulling 09e328a on RongtongJin:add-command into 034d738 on apache:develop.

@ShannonDing ShannonDing merged commit 0b6563b into apache:develop Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants