[ISSUE #5091] [Store-A] Speed up Broker initialization by concurrently loading ConsumeQueue #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Broker initialization
lizhimins
changed the title
lizhimins
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #5093 +/- ##
=============================================
+ Coverage 43.16% 43.32% +0.16%
- Complexity 7759 7802 +43
=============================================
Files 995 996 +1
Lines 69170 69289 +119
Branches 9154 9165 +11
=============================================
+ Hits 29855 30018 +163
+ Misses 35562 35508 -54
- Partials 3753 3763 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
ShannonDing
previously approved these changes
Sep 16, 2022
RongtongJin
reviewed
Sep 17, 2022
| long recoverCqStart = System.currentTimeMillis(); | ||
| long maxPhyOffsetOfConsumeQueue = this.recoverConsumeQueue(); | ||
| long recoverCqEnd = System.currentTimeMillis(); | ||
| private boolean recover(final boolean lastExitOK, final boolean recoverConcurrently) { |
There was a problem hiding this comment.
How about keeping the original function signature？ We can also get the brokerConfig in the recover function.
…g ConsumeQueue during Broker initialization
lizhimins
force-pushed
the
alibaba/store-A
branch
from
8dab33c
to
1ec50df
Compare
RongtongJin
approved these changes
Sep 19, 2022
caigy
approved these changes
Sep 19, 2022
Oliverwqcwrw
approved these changes
Sep 20, 2022
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.