Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pom.xml #5115

Merged
merged 1 commit into from Sep 19, 2022
Merged

Update pom.xml #5115

merged 1 commit into from Sep 19, 2022

Conversation

lfz757077613
Copy link
Contributor

maven-checkstyle-plugin use inputEncoding instead of encoding

maven-checkstyle-plugin use inputEncoding instaad of encoding
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -275,7 +275,7 @@
<phase>validate</phase>
<configuration>
<configLocation>style/rmq_checkstyle.xml</configLocation>
<encoding>UTF-8</encoding>
<inputEncoding>UTF-8</inputEncoding>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyou001 fuyou001 self-requested a review September 19, 2022 04:18
@codecov-commenter
Copy link

Codecov Report

Merging #5115 (18a8c13) into develop (b24ce72) will increase coverage by 0.07%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5115      +/-   ##
=============================================
+ Coverage      43.22%   43.29%   +0.07%     
- Complexity      7776     7785       +9     
=============================================
  Files            996      996              
  Lines          69233    69233              
  Branches        9159     9159              
=============================================
+ Hits           29927    29976      +49     
+ Misses         35539    35486      -53     
- Partials        3767     3771       +4     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...ava/org/apache/rocketmq/store/index/IndexFile.java 73.68% <0.00%> (-0.88%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.38% <0.00%> (-0.48%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.37% <0.00%> (-0.47%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 53.24% <0.00%> (-0.16%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.18% <0.00%> (-0.10%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 49.74% <0.00%> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.29% <0.00%> (+0.23%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-ai aaron-ai merged commit 8f4d925 into apache:develop Sep 19, 2022
@lfz757077613 lfz757077613 deleted the patch-1 branch September 19, 2022 05:32
drpmma pushed a commit that referenced this pull request Feb 21, 2023
maven-checkstyle-plugin use inputEncoding instaad of encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants