Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable merge button #5190

Merged
merged 1 commit into from Sep 27, 2022

Conversation

aaron-ai
Copy link
Member

revert #5175

@codecov-commenter
Copy link

Codecov Report

Merging #5190 (a4440b2) into develop (a3e5965) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5190      +/-   ##
=============================================
- Coverage      43.24%   43.24%   -0.01%     
+ Complexity      7805     7803       -2     
=============================================
  Files            997      997              
  Lines          69362    69362              
  Branches        9161     9161              
=============================================
- Hits           29999    29998       -1     
- Misses         35597    35601       +4     
+ Partials        3766     3763       -3     
Impacted Files Coverage Δ
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.75% <0.00%> (-0.63%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 38.67% <0.00%> (-0.56%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.22% <0.00%> (-0.54%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 37.63% <0.00%> (-0.54%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (ø)
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 71.77% <0.00%> (+0.26%) ⬆️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 62.38% <0.00%> (+0.91%) ⬆️
...va/org/apache/rocketmq/store/util/PerfCounter.java 66.49% <0.00%> (+2.09%) ⬆️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 85.71% <0.00%> (+5.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins lizhimins merged commit b607250 into apache:develop Sep 27, 2022
@lizhanhui
Copy link
Contributor

Why merge is enabled again? Isn't keeping commits linear satisfying?

nowinkeyy pushed a commit to nowinkeyy/rocketmq that referenced this pull request Sep 27, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants