Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #5236] fix ServiceProvider loading class #5237

Merged
merged 2 commits into from
Oct 3, 2022
Merged

[ISSUE #5236] fix ServiceProvider loading class #5237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d9285b
fix duplicate class loading
Sep 30, 2022
db11f6b
remove redundant
Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions common/src/main/java/org/apache/rocketmq/common/utils/ServiceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,24 +105,22 @@ protected static InputStream getResourceAsStream(ClassLoader loader, String name

public static <T> List<T> load(String name, Class<?> clazz) {
LOG.info("Looking for a resource file of name [{}] ...", name);
List<T> services = new ArrayList<T>();
List<T> services = new ArrayList<>();
try {
ArrayList<String> names = new ArrayList<String>();
final InputStream is = getResourceAsStream(getContextClassLoader(), name);
if (is != null) {
BufferedReader reader;
reader = new BufferedReader(new InputStreamReader(is, StandardCharsets.UTF_8));
String serviceName = reader.readLine();
List<String> names = new ArrayList<>();
while (serviceName != null && !"".equals(serviceName)) {
LOG.info(
"Creating an instance as specified by file {} which was present in the path of the context classloader.",
name);
if (!names.contains(serviceName)) {
names.add(serviceName);
services.add(initService(getContextClassLoader(), serviceName, clazz));
}

services.add((T) initService(getContextClassLoader(), serviceName, clazz));

serviceName = reader.readLine();
}
reader.close();
Expand Down