New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5254] Stream close optimization #5255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use try-with-resource?
Hmm, I'll change it |
Codecov Report
@@ Coverage Diff @@
## develop #5255 +/- ##
=============================================
+ Coverage 43.14% 43.19% +0.05%
- Complexity 7793 7800 +7
=============================================
Files 998 998
Lines 69459 69454 -5
Branches 9173 9171 -2
=============================================
+ Hits 29970 30004 +34
+ Misses 35715 35677 -38
+ Partials 3774 3773 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I've optimized using try-with-resource and removed the optional if null judgment from the method |
issue