Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5254] Stream close optimization #5255

Merged
merged 3 commits into from Oct 9, 2022

Conversation

RapperCL
Copy link
Contributor

@RapperCL RapperCL commented Oct 9, 2022

Copy link
Contributor

@lizhanhui lizhanhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use try-with-resource?

@RapperCL
Copy link
Contributor Author

RapperCL commented Oct 9, 2022

Why not use try-with-resource?

Hmm, I'll change it

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #5255 (76d243a) into develop (5be473a) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5255      +/-   ##
=============================================
+ Coverage      43.14%   43.19%   +0.05%     
- Complexity      7793     7800       +7     
=============================================
  Files            998      998              
  Lines          69459    69454       -5     
  Branches        9173     9171       -2     
=============================================
+ Hits           29970    30004      +34     
+ Misses         35715    35677      -38     
+ Partials        3774     3773       -1     
Impacted Files Coverage Δ
.../apache/rocketmq/common/utils/ServiceProvider.java 0.00% <0.00%> (ø)
...ketmq/client/impl/consumer/PullMessageService.java 49.23% <0.00%> (-3.08%) ⬇️
...che/rocketmq/container/BrokerContainerStartup.java 55.08% <0.00%> (-2.12%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-1.45%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.47% <0.00%> (-0.71%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 35.01% <0.00%> (-0.39%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.16% <0.00%> (-0.27%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 53.78% <0.00%> (-0.20%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RapperCL
Copy link
Contributor Author

RapperCL commented Oct 9, 2022

Why not use try-with-resource?

Hmm, I'll change it

I've optimized using try-with-resource and removed the optional if null judgment from the method

lizhanhui
lizhanhui previously approved these changes Oct 9, 2022
@lizhanhui lizhanhui changed the title 【ISSUE #5254】Stream close optimization 【ISSUE #5254Stream close optimization Oct 9, 2022
@lizhanhui lizhanhui changed the title 【ISSUE #5254Stream close optimization [ISSUE #5254] Stream close optimization Oct 9, 2022
@lizhanhui lizhanhui merged commit aa3feec into apache:develop Oct 9, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* Stream close optimization

* [ISSUE #5254] stream close optimization

* Fix check style violation by removing unused import

Co-authored-by: chenyong <chenyong@highlight.mobi>
Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants