Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5313] Optimize ReceiptHandleProcessor and GrpcChannelManager #5275

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Oct 11, 2022

What is the purpose of the change

Optimize proxy module ReceiptHandleProcessor and GrpcChannelManager methods

Brief changelog

  • Use channel to manage MessageReceiptHandle
  • Remove group in GrpcChannelManager
  • Add get method for ReceiptHandleGroup

lizhanhui
lizhanhui previously approved these changes Oct 14, 2022
@drpmma drpmma changed the title Optimize ReceiptHandleProcessor and GrpcChannelManager [ISSUE #5313] Optimize ReceiptHandleProcessor and GrpcChannelManager Oct 14, 2022
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhanhui lizhanhui merged commit be1b7d2 into apache:develop Oct 14, 2022
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
…nager (apache#5275)

* [ISSUE apache#5313] Optimize proxy module methods and interfaces

Use channel to manage MessageReceiptHandle

Remove group in GrpcChannelManager

* [ISSUE apache#5313] Add get method for ReceiptHandleGroup
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
…nager (apache#5275) (#13)

* [ISSUE apache#5313] Optimize proxy module methods and interfaces

Use channel to manage MessageReceiptHandle

Remove group in GrpcChannelManager

* [ISSUE apache#5313] Add get method for ReceiptHandleGroup

Co-authored-by: Zhouxiang Zhan <zhouxiang.zzx@alibaba-inc.com>
drpmma added a commit that referenced this pull request Feb 21, 2023
…5275)

* [ISSUE #5313] Optimize proxy module methods and interfaces

Use channel to manage MessageReceiptHandle

Remove group in GrpcChannelManager

* [ISSUE #5313] Add get method for ReceiptHandleGroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants