Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5281]Optimize the output of pressure results #5282

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

zhangjidi2016
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#5281

image

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Oliverwqcwrw
Oliverwqcwrw previously approved these changes Oct 12, 2022
Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caigy
caigy previously approved these changes Oct 12, 2022
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #5282 (84e9c2a) into develop (8d10c96) will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5282      +/-   ##
=============================================
+ Coverage      43.20%   43.24%   +0.04%     
  Complexity      7807     7807              
=============================================
  Files            998      998              
  Lines          69451    69451              
  Branches        9169     9169              
=============================================
+ Hits           30003    30036      +33     
+ Misses         35682    35646      -36     
- Partials        3766     3769       +3     
Impacted Files Coverage Δ
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 55.26% <0.00%> (-1.18%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.75% <0.00%> (-1.10%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 33.97% <0.00%> (-0.56%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 37.63% <0.00%> (-0.54%) ⬇️
...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java 50.24% <0.00%> (-0.50%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 49.74% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

odbozhou
odbozhou previously approved these changes Oct 13, 2022
@lizhanhui lizhanhui merged commit f4ff225 into apache:develop Nov 9, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
Co-authored-by: zhangjidi <zhangjidi@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants