[ISSUE #5292] [RIP-48] Support reset offset in server-side to improve the success rate #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
changed the title
|
Please help review this pr |
lizhimins
changed the title
odbozhou
previously approved these changes
Oct 13, 2022
xdkxlk
reviewed
Oct 13, 2022
common/src/main/java/org/apache/rocketmq/common/protocol/header/ResetOffsetRequestHeader.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #5293 +/- ##
=============================================
- Coverage 43.21% 43.10% -0.12%
+ Complexity 7805 7800 -5
=============================================
Files 998 998
Lines 69438 69607 +169
Branches 9167 9193 +26
=============================================
- Hits 30011 30007 -4
- Misses 35659 35827 +168
- Partials 3768 3773 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lizhanhui
force-pushed
the
offset/server-offset-3
branch
from
dd298fe
to
776af3a
Compare
|
Rebase to fix file conflicts |
lizhanhui
approved these changes
Oct 14, 2022
6 tasks
anuragmadnawat1
pushed a commit
to anuragmadnawat1/rocketmq
that referenced
this pull request
Nov 2, 2022
…mprove the success rate (apache#5293) * [RIP-48] Support reset offset in server side to improve the success rate * [RIP-48] Support reset offset in server side to improve the success rate * [RIP-48] Fix code style * fix unit test * no need put offset in reset command header Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
anuragmadnawat1
added a commit
to anuragmadnawat1/rocketmq
that referenced
this pull request
Nov 2, 2022
…mprove the success rate (apache#5293) (#9) * [RIP-48] Support reset offset in server side to improve the success rate * [RIP-48] Support reset offset in server side to improve the success rate * [RIP-48] Fix code style * fix unit test * no need put offset in reset command header Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com> Co-authored-by: lizhimins <707364882@qq.com> Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
… the success rate (#5293) * [RIP-48] Support reset offset in server side to improve the success rate * [RIP-48] Support reset offset in server side to improve the success rate * [RIP-48] Fix code style * fix unit test * no need put offset in reset command header Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.