Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5204] Enable checkstyle for test code (all module) #5297

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

nowinkeyy
Copy link
Contributor

@nowinkeyy nowinkeyy commented Oct 12, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5204

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Oliverwqcwrw
Oliverwqcwrw previously approved these changes Oct 13, 2022
lizhanhui
lizhanhui previously approved these changes Oct 14, 2022
@lizhanhui lizhanhui dismissed stale reviews from Oliverwqcwrw and themself via 0467905 October 14, 2022 02:13
@codecov-commenter
Copy link

Codecov Report

Merging #5297 (0467905) into develop (8d10c96) will increase coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5297      +/-   ##
=============================================
+ Coverage      43.20%   43.23%   +0.03%     
- Complexity      7807     7816       +9     
=============================================
  Files            998      998              
  Lines          69451    69451              
  Branches        9169     9169              
=============================================
+ Hits           30003    30024      +21     
+ Misses         35682    35655      -27     
- Partials        3766     3772       +6     
Impacted Files Coverage Δ
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 56.04% <0.00%> (-3.30%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.16% <0.00%> (-1.62%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 55.26% <0.00%> (-1.18%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.46% <0.00%> (-0.92%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java 50.24% <0.00%> (-0.50%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.37% <0.00%> (-0.47%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 34.53% <0.00%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui merged commit 53e0847 into apache:develop Oct 14, 2022
@nowinkeyy nowinkeyy deleted the rocketmq-5204 branch October 14, 2022 06:33
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
…che#5297)

* delete the checkstyle plugin for child modules

* [ISSUE apache#5204] Enable checkstyle for test code (all module)

* Exclude generated files

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
…che#5297) (#5)

* delete the checkstyle plugin for child modules

* [ISSUE apache#5204] Enable checkstyle for test code (all module)

* Exclude generated files

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>

Co-authored-by: Nowinkey <nowinkey@tom.com>
Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* delete the checkstyle plugin for child modules

* [ISSUE #5204] Enable checkstyle for test code (all module)

* Exclude generated files

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable checkstyle for test code (all module)
4 participants