Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5298]Polish code style for jdk8+ #5308

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Oct 13, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5298

Brief changelog

  • Polish code style for jdk8+
  • Remove tools model test useless import

Verifying this change

build project after change
image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@echooymxq
Copy link
Contributor

RocketMQ base on java8, you did a great job. Actually, while i was reading the source code, there are many code smells, but I have no motivation to fix it.

@lizhanhui lizhanhui merged commit db1f183 into apache:develop Oct 14, 2022
@mxsm mxsm deleted the rocketmq-5298 branch October 14, 2022 05:41
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish code style for jdk8+
3 participants