Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5307] Remove redundant if statements #5314

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

nowinkeyy
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #5307

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5314 (9519fbd) into develop (0c73f15) will increase coverage by 0.02%.
The diff coverage is 19.35%.

@@              Coverage Diff              @@
##             develop    #5314      +/-   ##
=============================================
+ Coverage      43.10%   43.12%   +0.02%     
- Complexity      7803     7809       +6     
=============================================
  Files            998     1001       +3     
  Lines          69605    69632      +27     
  Branches        9193     9197       +4     
=============================================
+ Hits           30004    30031      +27     
- Misses         35822    35826       +4     
+ Partials        3779     3775       -4     
Impacted Files Coverage Δ
...pache/rocketmq/common/attribute/CleanupPolicy.java 0.00% <0.00%> (ø)
...pache/rocketmq/common/utils/DeletePolicyUtils.java 0.00% <0.00%> (ø)
...n/java/org/apache/rocketmq/proxy/ProxyStartup.java 47.20% <0.00%> (-0.39%) ⬇️
...ocketmq/proxy/common/AbstractStartAndShutdown.java 23.07% <0.00%> (-4.20%) ⬇️
...apache/rocketmq/proxy/common/StartAndShutdown.java 0.00% <0.00%> (ø)
...ocketmq/broker/processor/SendMessageProcessor.java 44.15% <16.66%> (-0.48%) ⬇️
...va/org/apache/rocketmq/common/TopicAttributes.java 92.30% <100.00%> (+2.30%) ⬆️
...org/apache/rocketmq/store/DefaultMessageStore.java 53.74% <100.00%> (+0.08%) ⬆️
...va/org/apache/rocketmq/store/util/PerfCounter.java 64.39% <0.00%> (-2.10%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui merged commit 7a4fa6b into apache:develop Oct 27, 2022
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whether the if statement is redundant?
6 participants