Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE ##5354] Implement broker metrics framework #5355

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

ShadowySpirits
Copy link
Member

link to #5354

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #5355 (bc5ed53) into develop (3df2842) will increase coverage by 0.05%.
The diff coverage is 20.48%.

❗ Current head bc5ed53 differs from pull request most recent head 7de8134. Consider uploading reports for the commit 7de8134 to get more accurate results

@@              Coverage Diff              @@
##             develop    #5355      +/-   ##
=============================================
+ Coverage      43.04%   43.09%   +0.05%     
- Complexity      7794     7823      +29     
=============================================
  Files           1001     1003       +2     
  Lines          69684    69850     +166     
  Branches        9205     9226      +21     
=============================================
+ Hits           29992    30103     +111     
- Misses         35909    35966      +57     
+ Partials        3783     3781       -2     
Impacted Files Coverage Δ
...rocketmq/broker/metrics/BrokerMetricsConstant.java 0.00% <0.00%> (ø)
.../rocketmq/broker/metrics/BrokerMetricsManager.java 13.40% <13.40%> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 28.35% <29.85%> (+0.18%) ⬆️
...a/org/apache/rocketmq/broker/BrokerController.java 43.73% <100.00%> (+0.05%) ⬆️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <0.00%> (-5.36%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 55.26% <0.00%> (-1.18%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.53% <0.00%> (-0.63%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui changed the title implement broker metrics framework [ISSUE ##5354] Implement broker metrics framework Oct 19, 2022
@lizhanhui lizhanhui merged commit 6e27b54 into apache:develop Oct 19, 2022
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
* implement broker metrics framework

* update bazel config

* Fix Bazel deps

* Fix unnecessary mocking issue

* Fix bazel compile warning

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
…#23)

* implement broker metrics framework

* update bazel config

* Fix Bazel deps

* Fix unnecessary mocking issue

* Fix bazel compile warning

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>

Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* implement broker metrics framework

* update bazel config

* Fix Bazel deps

* Fix unnecessary mocking issue

* Fix bazel compile warning

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants