Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5370]Upgrade commons-cli:commons-cli to 1.5.0 #5371

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Oct 20, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5370

Brief changelog

  • Upgrade commons-cli version to 1.5.0 in WORKSPACE

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@mxsm mxsm changed the title [ISSUE #5370]Upgrade commons-cli version to 1.5.0 in WORKSPACE [ISSUE #5370]Upgrade commons-cli:commons-cli to 1.5.0 Oct 20, 2022
@@ -59,7 +59,7 @@ maven_install(
"io.opentracing:opentracing-mock:0.33.0",
"commons-collections:commons-collections:3.2.2",
"org.awaitility:awaitility:4.1.0",
"commons-cli:commons-cli:1.4",
"commons-cli:commons-cli:1.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version in pom be upgraded as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pom has upgraded!

@RongtongJin RongtongJin merged commit 5ab7b0d into apache:develop Oct 21, 2022
@mxsm mxsm deleted the rocketmq-5370 branch October 21, 2022 14:04
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade commons-cli:commons-cli to 1.5.0
4 participants