-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5331]Fix ConsumeQueueTest stable sleep cause NPE. #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunghanjacktsai
previously approved these changes
Oct 25, 2022
caigy
reviewed
Oct 25, 2022
store/src/test/java/org/apache/rocketmq/store/ConsumeQueueTest.java
Outdated
Show resolved
Hide resolved
lizhanhui
reviewed
Oct 25, 2022
store/src/test/java/org/apache/rocketmq/store/ConsumeQueueTest.java
Outdated
Show resolved
Hide resolved
lizhanhui
previously approved these changes
Oct 25, 2022
Codecov Report
@@ Coverage Diff @@
## develop #5397 +/- ##
=============================================
- Coverage 43.24% 43.13% -0.11%
- Complexity 7881 8002 +121
=============================================
Files 1006 1016 +10
Lines 70046 71499 +1453
Branches 9259 9463 +204
=============================================
+ Hits 30290 30844 +554
- Misses 35963 36766 +803
- Partials 3793 3889 +96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lizhanhui
approved these changes
Oct 27, 2022
anuragmadnawat1
pushed a commit
to anuragmadnawat1/rocketmq
that referenced
this pull request
Nov 2, 2022
…he#5397) * [ISSUE apache#5331]Fix ConsumeQueueTest stable sleep cause NPE. * Use awaitability to achieve granular condition check * Add a timeout duration for condition check * Add a timeout duration for condition check Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
anuragmadnawat1
added a commit
to anuragmadnawat1/rocketmq
that referenced
this pull request
Nov 2, 2022
…he#5397) (#38) * [ISSUE apache#5331]Fix ConsumeQueueTest stable sleep cause NPE. * Use awaitability to achieve granular condition check * Add a timeout duration for condition check * Add a timeout duration for condition check Co-authored-by: Li Zhanhui <lizhanhui@gmail.com> Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
* [ISSUE #5331]Fix ConsumeQueueTest stable sleep cause NPE. * Use awaitability to achieve granular condition check * Add a timeout duration for condition check * Add a timeout duration for condition check Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
develop
What is the purpose of the change
Link #5331
https://github.com/apache/rocketmq/actions/runs/3311538539/jobs/5467110216
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.