-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5424]fix null exception and array overflow bug exist in getHalfMsg method #5425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5425 +/- ##
=============================================
- Coverage 43.17% 43.17% -0.01%
+ Complexity 8046 8045 -1
=============================================
Files 1020 1020
Lines 71892 71895 +3
Branches 9519 9521 +2
=============================================
+ Hits 31039 31040 +1
+ Misses 36946 36940 -6
- Partials 3907 3915 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caigy
approved these changes
Oct 31, 2022
RongtongJin
approved these changes
Oct 31, 2022
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
RongtongJin
pushed a commit
to RongtongJin/rocketmq
that referenced
this pull request
Mar 20, 2023
…n getHalfMsg method apache#5425 (cherry picked from commit dd4b666)
odbozhou
pushed a commit
that referenced
this pull request
Mar 21, 2023
…#6410) * [ISSUE #4841] Fix the reply message is the original request msg. (#4896) (cherry picked from commit f7c2072) * [ISSUE #4647] Update CommandLineOption secretKey to necessary (#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE #4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE #5424] Fix null exception and array overflow bug exist in getHalfMsg method #5425 (cherry picked from commit dd4b666) * [ISSUE #4841] Fix the reply message is the original request msg. (#4896) (cherry picked from commit f7c2072) * [ISSUE #4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Feb 23, 2024
…branch (apache#6410) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE apache#4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425 (cherry picked from commit dd4b666) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Mar 1, 2024
…branch (apache#6410) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE apache#4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425 (cherry picked from commit dd4b666) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Mar 9, 2024
…branch (apache#6410) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE apache#4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425 (cherry picked from commit dd4b666) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Mar 9, 2024
…branch (apache#6410) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE apache#4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425 (cherry picked from commit dd4b666) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Mar 26, 2024
…branch (apache#6410) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE apache#4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425 (cherry picked from commit dd4b666) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Apr 2, 2024
…branch (apache#6410) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648) * Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI * [ISSUE apache#4647] udpate option to necessary Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn> (cherry picked from commit a3aef17) * [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker (cherry picked from commit 3a1d1a7) * [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425 (cherry picked from commit dd4b666) * [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896) (cherry picked from commit f7c2072) * [ISSUE apache#4584] Add new persist method to update consume offset to remote server. (cherry picked from commit 2930994) * Prepare to release 4.9.5 --------- Co-authored-by: echooymxq <echooy.mxq@gmail.com> Co-authored-by: Oliver <wqdyxnbd@163.com> Co-authored-by: JanWarlen <janwarlen@gmail.com> Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com> Co-authored-by: dinglei <libya_003@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue