Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5424]fix null exception and array overflow bug exist in getHalfMsg method #5425

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

RapperCL
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Merging #5425 (2df6c9e) into develop (4ba8aa2) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

@@              Coverage Diff              @@
##             develop    #5425      +/-   ##
=============================================
- Coverage      43.17%   43.17%   -0.01%     
+ Complexity      8046     8045       -1     
=============================================
  Files           1020     1020              
  Lines          71892    71895       +3     
  Branches        9519     9521       +2     
=============================================
+ Hits           31039    31040       +1     
+ Misses         36946    36940       -6     
- Partials        3907     3915       +8     
Impacted Files Coverage Δ
...saction/queue/TransactionalMessageServiceImpl.java 50.89% <66.66%> (-0.39%) ⬇️
...apache/rocketmq/acl/plain/PlainAccessResource.java 57.57% <75.00%> (-0.08%) ⬇️
...apache/rocketmq/broker/longpolling/PopRequest.java 31.03% <0.00%> (-13.80%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 73.11% <0.00%> (-2.16%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-1.45%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 68.46% <0.00%> (-0.91%) ⬇️
...he/rocketmq/controller/impl/DLedgerController.java 65.96% <0.00%> (-0.53%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 53.42% <0.00%> (-0.16%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 65.39% <0.00%> (-0.11%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit dd4b666 into apache:develop Oct 31, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
@RongtongJin RongtongJin added this to the 4.9.5 milestone Mar 20, 2023
@RongtongJin RongtongJin added the LTS 4.9.x This PR should cherry picked to LTS branch label Mar 20, 2023
RongtongJin pushed a commit to RongtongJin/rocketmq that referenced this pull request Mar 20, 2023
odbozhou pushed a commit that referenced this pull request Mar 21, 2023
…#6410)

* [ISSUE #4841] Fix the reply message is the original request msg. (#4896)

(cherry picked from commit f7c2072)

* [ISSUE #4647] Update CommandLineOption secretKey to necessary (#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE #4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE #5424] Fix null exception and array overflow bug exist in getHalfMsg method #5425

(cherry picked from commit dd4b666)

* [ISSUE #4841] Fix the reply message is the original request msg. (#4896)

(cherry picked from commit f7c2072)

* [ISSUE #4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Feb 23, 2024
…branch (apache#6410)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE apache#4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425

(cherry picked from commit dd4b666)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Mar 1, 2024
…branch (apache#6410)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE apache#4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425

(cherry picked from commit dd4b666)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Mar 9, 2024
…branch (apache#6410)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE apache#4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425

(cherry picked from commit dd4b666)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Mar 9, 2024
…branch (apache#6410)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE apache#4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425

(cherry picked from commit dd4b666)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Mar 26, 2024
…branch (apache#6410)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE apache#4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425

(cherry picked from commit dd4b666)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Apr 2, 2024
…branch (apache#6410)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4647] Update CommandLineOption secretKey to necessary (apache#4648)

* Ignore the unstable updateGlobalWhiteRemoteAddressesTest in the arm environment of CI

* [ISSUE apache#4647] udpate option to necessary

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
(cherry picked from commit a3aef17)

* [ISSUE apache#4644] Fix mqadmin deleteTopic bug when command exec on slave broker

(cherry picked from commit 3a1d1a7)

* [ISSUE apache#5424] Fix null exception and array overflow bug exist in getHalfMsg method apache#5425

(cherry picked from commit dd4b666)

* [ISSUE apache#4841] Fix the reply message is the original request msg. (apache#4896)

(cherry picked from commit f7c2072)

* [ISSUE apache#4584] Add new persist method to update consume offset to remote server.

(cherry picked from commit 2930994)

* Prepare to release 4.9.5

---------

Co-authored-by: echooymxq <echooy.mxq@gmail.com>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Co-authored-by: JanWarlen <janwarlen@gmail.com>
Co-authored-by: RapperCL <44110731+RapperCL@users.noreply.github.com>
Co-authored-by: dinglei <libya_003@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS 4.9.x This PR should cherry picked to LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants