-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#5331] Fix windows can't move file when mmapped. #5434
Conversation
a7258cd
to
6890f63
Compare
Looks like we cannot verify the fix in CI as it keeps failing... |
The ci failed because of other unstable tests, i will fixing in other prs, you can verify it if you use windows. But this change point is notable, it will cause jvm crash when use the mmaped buffer if has cleaned, so i remapped here. |
@echooymxq Let's work it out this way: PR5345 makes all pipelines pass through conditionally skipping test cases that are not compatible with Windows at the present. Let's merge that pull request first, then rebase this pull request, which essentially fixes some failing cases. |
This pull request itself is good and helpful. As I just replied, let's merge it after pull-request 5345 |
6890f63
to
b034a5f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5434 +/- ##
=============================================
- Coverage 43.18% 43.17% -0.02%
- Complexity 8070 8073 +3
=============================================
Files 1025 1025
Lines 72177 72194 +17
Branches 9558 9560 +2
=============================================
Hits 31173 31173
- Misses 37064 37086 +22
+ Partials 3940 3935 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Got it. |
Make sure set the target branch to
develop
What is the purpose of the change
Link #5331
https://github.com/apache/rocketmq/actions/runs/3335676387/jobs/5520208604
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.