[RIP-48] Support reset offset in server-side for pop message #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
commented
Nov 3, 2022
| @@ -25,26 +25,31 @@ | |||
| import org.apache.rocketmq.test.util.RandomUtil; | |||
|
|
|||
| public class RMQNormalConsumer extends AbstractMQConsumer { | |||
| private static Logger logger = Logger.getLogger(RMQNormalConsumer.class); | |||
|
|
|||
| private static final Logger LOGGER = Logger.getLogger(RMQNormalConsumer.class); | |||
lizhimins
commented
Nov 3, 2022
| public RMQPopConsumer(String nsAddr, String topic, String subExpression, | ||
| String consumerGroup, AbstractListener listner) { |
Codecov Report
@@ Coverage Diff @@
## develop #5457 +/- ##
=============================================
- Coverage 43.17% 43.17% -0.01%
- Complexity 8046 8071 +25
=============================================
Files 1020 1025 +5
Lines 71892 72207 +315
Branches 9519 9560 +41
=============================================
+ Hits 31039 31172 +133
- Misses 36946 37096 +150
- Partials 3907 3939 +32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
reviewed
Nov 3, 2022
broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOrderInfoManager.java
Show resolved
Hide resolved
lizhanhui
force-pushed
the
offset/pop-reset2
branch
from
910fe16
to
1c980b1
Compare
|
Rebase to make CI pass |
lizhanhui
approved these changes
Nov 7, 2022
RongtongJin
approved these changes
Nov 7, 2022
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
* [RIP-48] Support reset offset in server-side for pop message * [RIP-48] Support reset offset in server-side for pop message * no need remove error log Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RIP-48] Support reset offset in server-side for pop message