Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5437] Add log info for push consumer when execute hook failed #5468

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Nov 5, 2022

closes #5437

@codecov-commenter
Copy link

Codecov Report

Merging #5468 (74af205) into develop (dd95a5b) will increase coverage by 0.00%.
The diff coverage is 31.01%.

@@             Coverage Diff             @@
##             develop    #5468    +/-   ##
===========================================
  Coverage      43.17%   43.17%            
- Complexity      8050     8061    +11     
===========================================
  Files           1021     1025     +4     
  Lines          71999    72196   +197     
  Branches        9537     9560    +23     
===========================================
+ Hits           31082    31171    +89     
- Misses         36985    37077    +92     
- Partials        3932     3948    +16     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 46.44% <0.00%> (+2.67%) ⬆️
...rocketmq/broker/metrics/BrokerMetricsConstant.java 0.00% <ø> (ø)
.../rocketmq/broker/metrics/NopLongUpDownCounter.java 0.00% <0.00%> (ø)
...ocketmq/broker/processor/PeekMessageProcessor.java 3.40% <0.00%> (-0.20%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 40.56% <0.00%> (-0.92%) ⬇️
.../transaction/queue/TransactionalMessageBridge.java 69.51% <0.00%> (-2.71%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 32.12% <0.00%> (-0.09%) ⬇️
...he/rocketmq/common/attribute/TopicMessageType.java 91.66% <0.00%> (-8.34%) ⬇️
.../apache/rocketmq/common/utils/ServiceProvider.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 53.62% <0.00%> (+0.04%) ⬆️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zhouxinyu
zhouxinyu previously approved these changes Nov 7, 2022
@lizhanhui
Copy link
Contributor

Rebase to make all CI pipelines pass

@lizhanhui lizhanhui merged commit 9b2375d into apache:develop Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add push consumer execute hook logs.
4 participants