[ISSUE #5481] Decrease the repeated consumption probability of expired message #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ai
requested review from
drpmma,
lizhimins,
lollipopjin,
zhouxinyu and
xdkxlk
aaron-ai
changed the title
lizhanhui
reviewed
Nov 9, 2022
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
Outdated
Show resolved
Hide resolved
lizhanhui
reviewed
Nov 9, 2022
...rc/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #5483 +/- ##
=============================================
- Coverage 43.18% 43.14% -0.05%
+ Complexity 8066 8065 -1
=============================================
Files 1025 1025
Lines 72195 72245 +50
Branches 9559 9564 +5
=============================================
- Hits 31180 31167 -13
- Misses 37067 37130 +63
Partials 3948 3948
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lizhanhui
approved these changes
Nov 9, 2022
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
…d message (#5483) * Decrease the repeated consumption probability of expired message * Polish code * Make test method name consistent with that of main source file Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5481