Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5449] [RIP-46] implement remoting stats metrics #5487

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

ShadowySpirits
Copy link
Member

link to #5449

@ShadowySpirits ShadowySpirits force-pushed the broker_metrics branch 3 times, most recently from ff626cf to a2cdb2d Compare November 9, 2022 05:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #5487 (a2cdb2d) into develop (9b2375d) will decrease coverage by 0.09%.
The diff coverage is 24.18%.

❗ Current head a2cdb2d differs from pull request most recent head d829c9a. Consider uploading reports for the commit d829c9a to get more accurate results

@@              Coverage Diff              @@
##             develop    #5487      +/-   ##
=============================================
- Coverage      43.18%   43.09%   -0.10%     
+ Complexity      8066     8059       -7     
=============================================
  Files           1025     1026       +1     
  Lines          72195    72340     +145     
  Branches        9559     9566       +7     
=============================================
- Hits           31180    31173       -7     
- Misses         37067    37218     +151     
- Partials        3948     3949       +1     
Impacted Files Coverage Δ
.../rocketmq/broker/metrics/BrokerMetricsManager.java 15.73% <0.00%> (-0.55%) ⬇️
...cketmq/broker/offset/ConsumerOrderInfoManager.java 76.15% <0.00%> (-1.10%) ⬇️
...broker/processor/AbstractSendMessageProcessor.java 34.87% <0.00%> (-3.92%) ⬇️
...ocketmq/broker/processor/AdminBrokerProcessor.java 25.04% <0.00%> (ø)
...cketmq/broker/processor/NotificationProcessor.java 10.90% <0.00%> (+0.32%) ⬆️
...ocketmq/broker/processor/PeekMessageProcessor.java 3.22% <0.00%> (-0.18%) ⬇️
...ocketmq/broker/processor/PullMessageProcessor.java 27.72% <0.00%> (+0.06%) ⬆️
...cketmq/broker/processor/QueryMessageProcessor.java 4.65% <0.00%> (-1.07%) ⬇️
...src/main/java/org/apache/rocketmq/common/Pair.java 60.00% <ø> (ø)
...apache/rocketmq/common/metrics/NopLongCounter.java 0.00% <ø> (ø)
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShadowySpirits ShadowySpirits marked this pull request as ready for review November 9, 2022 06:46
@lizhanhui
Copy link
Contributor

Module common depends on remoting is somewhat weird... We should invert the dependency and relocate all shared classes into common. This pull request moves some classes from common to remoting, deteriorating the inverted dependency relation a step further.

@lizhanhui lizhanhui merged commit 0ae1bd2 into apache:develop Nov 9, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* implement remoting metrics

* fix bazel

* add metrics view & fix unit test

* move remoting command process timer to NettyDecoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants