Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5490] add metrics view & fix unit test #5491

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

ShadowySpirits
Copy link
Member

fix #5490

@codecov-commenter
Copy link

Codecov Report

Merging #5491 (148d71f) into develop (9b2375d) will increase coverage by 0.05%.
The diff coverage is 22.03%.

@@              Coverage Diff              @@
##             develop    #5491      +/-   ##
=============================================
+ Coverage      43.18%   43.24%   +0.05%     
- Complexity      8066     8081      +15     
=============================================
  Files           1025     1025              
  Lines          72195    72232      +37     
  Branches        9559     9563       +4     
=============================================
+ Hits           31180    31236      +56     
+ Misses         37067    37044      -23     
- Partials        3948     3952       +4     
Impacted Files Coverage Δ
...cketmq/broker/offset/ConsumerOrderInfoManager.java 76.15% <0.00%> (-1.10%) ⬇️
...va/org/apache/rocketmq/namesrv/NamesrvStartup.java 15.83% <0.00%> (ø)
...he/rocketmq/test/client/rmq/RMQNormalConsumer.java 0.00% <0.00%> (ø)
.../apache/rocketmq/test/client/rmq/RMQPopClient.java 0.00% <0.00%> (ø)
...pache/rocketmq/test/client/rmq/RMQPopConsumer.java 0.00% <0.00%> (ø)
.../apache/rocketmq/test/factory/ConsumerFactory.java 0.00% <0.00%> (ø)
...rg/apache/rocketmq/test/util/MQAdminTestUtils.java 0.00% <ø> (ø)
...org/apache/rocketmq/tools/command/CommandUtil.java 31.16% <0.00%> (-3.12%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 37.39% <52.63%> (+0.08%) ⬆️
...cketmq/broker/schedule/ScheduleMessageService.java 58.04% <100.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui merged commit 0ffb32f into apache:develop Nov 9, 2022
@ShadowySpirits ShadowySpirits deleted the fix_namesrv_startup_tip branch November 10, 2022 08:47
drpmma pushed a commit that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix name server startup tip typo
3 participants