Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #4330]Fix some comments in DefaultElectPolicy #5546

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

hzh0425
Copy link
Member

@hzh0425 hzh0425 commented Nov 19, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix some comments in DefaultElectPolicy

Brief changelog

Fix some comments in DefaultElectPolicy

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5546 (bc9055d) into develop (a7c1d49) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #5546      +/-   ##
=============================================
- Coverage      43.18%   42.79%   -0.39%     
- Complexity      8009     8040      +31     
=============================================
  Files           1016     1031      +15     
  Lines          71535    72741    +1206     
  Branches        9467     9613     +146     
=============================================
+ Hits           30891    31132     +241     
- Misses         36751    37668     +917     
- Partials        3893     3941      +48     
Impacted Files Coverage Δ
...etmq/controller/elect/impl/DefaultElectPolicy.java 75.00% <100.00%> (ø)
...che/rocketmq/common/consumer/ConsumeFromWhere.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/rocketmq/common/utils/CheckpointFile.java 0.00% <0.00%> (-74.55%) ⬇️
...apache/rocketmq/remoting/common/ServiceThread.java 0.00% <0.00%> (-73.34%) ⬇️
...g/apache/rocketmq/common/message/MessageQueue.java 0.00% <0.00%> (-45.46%) ⬇️
...he/rocketmq/broker/mqtrace/SendMessageContext.java 34.34% <0.00%> (-28.29%) ⬇️
.../apache/rocketmq/common/filter/ExpressionType.java 0.00% <0.00%> (-25.00%) ⬇️
...n/java/org/apache/rocketmq/common/TopicConfig.java 36.84% <0.00%> (-19.55%) ⬇️
...he/rocketmq/common/attribute/TopicMessageType.java 91.66% <0.00%> (-8.34%) ⬇️
...ocketmq/broker/processor/SendMessageProcessor.java 37.74% <0.00%> (-6.42%) ⬇️
... and 592 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin merged commit 44072e6 into apache:develop Nov 19, 2022
@RongtongJin RongtongJin added the module/ha high availably related label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants