Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5549] Move the header of the controller to the upper layer #5550

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Close #5549
Move the header of the controller to the upper layer

Brief changelog

Move the header of the controller to the upper layer

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

@codecov-commenter
Copy link

Codecov Report

Merging #5550 (ae38083) into develop (da5a5b6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #5550      +/-   ##
=============================================
- Coverage      42.71%   42.68%   -0.04%     
+ Complexity      8031     8022       -9     
=============================================
  Files           1031     1031              
  Lines          72743    72743              
  Branches        9614     9614              
=============================================
- Hits           31073    31049      -24     
- Misses         37734    37750      +16     
- Partials        3936     3944       +8     
Impacted Files Coverage Δ
...he/rocketmq/broker/controller/ReplicasManager.java 43.09% <ø> (ø)
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 17.42% <ø> (ø)
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 22.95% <ø> (ø)
.../apache/rocketmq/controller/ControllerManager.java 73.11% <ø> (-2.16%) ⬇️
...q/controller/impl/manager/ReplicasInfoManager.java 62.21% <ø> (ø)
...ntroller/processor/ControllerRequestProcessor.java 23.95% <ø> (ø)
...der/controller/AlterSyncStateSetRequestHeader.java 0.00% <ø> (ø)
...er/controller/AlterSyncStateSetResponseHeader.java 0.00% <ø> (ø)
...roller/CleanControllerBrokerDataRequestHeader.java 0.00% <ø> (ø)
...ol/header/controller/ElectMasterRequestHeader.java 0.00% <ø> (ø)
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@lizhanhui lizhanhui merged commit d781271 into apache:develop Nov 20, 2022
@RongtongJin RongtongJin added the module/ha high availably related label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is inappropriate that the headers of the controller are under namesrv directory
5 participants