Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5566] Fix flaky test of AutoSwitchHATest #5567

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Close #5566

Brief changelog

Fix flaky test of AutoSwitchHATest

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5567 (b14b21c) into develop (ee37e3a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5567      +/-   ##
=============================================
+ Coverage      42.43%   42.45%   +0.01%     
- Complexity      7936     7946      +10     
=============================================
  Files           1022     1022              
  Lines          71243    71243              
  Branches        9399     9399              
=============================================
+ Hits           30234    30247      +13     
+ Misses         37181    37162      -19     
- Partials        3828     3834       +6     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...ache/rocketmq/store/AllocateMappedFileService.java 39.28% <0.00%> (-2.39%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 46.60% <0.00%> (-2.27%) ⬇️
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 65.30% <0.00%> (-2.05%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-1.45%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 72.16% <0.00%> (-0.82%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (-0.52%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.29% <0.00%> (-0.10%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.06% <0.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@odbozhou odbozhou merged commit 9ce4bd3 into apache:develop Nov 22, 2022
RongtongJin added a commit to RongtongJin/rocketmq that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoSwitchHATest is a flaky test
3 participants