-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic #5633
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5633 +/- ##
=============================================
- Coverage 42.39% 42.38% -0.01%
- Complexity 7967 7971 +4
=============================================
Files 1023 1023
Lines 71479 71493 +14
Branches 9444 9449 +5
=============================================
- Hits 30305 30304 -1
- Misses 37332 37344 +12
- Partials 3842 3845 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
@RongtongJin PTAL~ |
…pache#5633) * [ISSUE apache#5631]optimize ReplicasInfoManager#registerBroker logic * fix code style
…pache#5633) * [ISSUE apache#5631]optimize ReplicasInfoManager#registerBroker logic * fix code style
Make sure set the target branch to
develop
What is the purpose of the change
Fix #5631
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.