Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic #5633

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Dec 1, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #5631

Brief changelog

  • Fix ReplicasInfoManager#registerBroker not check master is alive

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@mxsm mxsm changed the title [ISSUE #5631]Fix ReplicasInfoManager#registerBroker not check master is alive [ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic Dec 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5633 (99bba01) into develop (e5fadc7) will decrease coverage by 0.00%.
The diff coverage is 57.89%.

@@              Coverage Diff              @@
##             develop    #5633      +/-   ##
=============================================
- Coverage      42.39%   42.38%   -0.01%     
- Complexity      7967     7971       +4     
=============================================
  Files           1023     1023              
  Lines          71479    71493      +14     
  Branches        9444     9449       +5     
=============================================
- Hits           30305    30304       -1     
- Misses         37332    37344      +12     
- Partials        3842     3845       +3     
Impacted Files Coverage Δ
...q/controller/impl/manager/ReplicasInfoManager.java 61.23% <55.55%> (-0.99%) ⬇️
...he/rocketmq/controller/impl/DLedgerController.java 66.49% <100.00%> (ø)
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <0.00%> (-5.36%) ⬇️
...mq/broker/topic/TopicQueueMappingCleanService.java 12.43% <0.00%> (-3.63%) ⬇️
...rocketmq/common/message/MessageClientIDSetter.java 71.42% <0.00%> (-2.39%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.50% <0.00%> (-0.89%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 34.53% <0.00%> (-0.56%) ⬇️
...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java 50.24% <0.00%> (-0.50%) ⬇️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 76.29% <0.00%> (-0.38%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@hzh0425 hzh0425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ni-ze ni-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@mxsm
Copy link
Member Author

mxsm commented Dec 9, 2022

@RongtongJin PTAL~

@hzh0425 hzh0425 merged commit e5c3f21 into apache:develop Dec 10, 2022
@mxsm mxsm deleted the rocketmq-5631 branch December 10, 2022 14:27
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
…pache#5633)

* [ISSUE apache#5631]optimize ReplicasInfoManager#registerBroker logic

* fix code style
RongtongJin pushed a commit to RongtongJin/rocketmq that referenced this pull request Jan 10, 2023
…pache#5633)

* [ISSUE apache#5631]optimize ReplicasInfoManager#registerBroker logic

* fix code style
@RongtongJin RongtongJin added the module/ha high availably related label Feb 14, 2023
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* [ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReplicasInfoManager#registerBroker not check master is alive
8 participants