Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5639] Deprecated the ambiguous methods of lite pull consumer #5640

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Close #5639
Deprecated the ambiguous methods of lite pull consumer

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin changed the title [ISSUE #5639]Deprecated the ambiguous methods of lite pull consumer [ISSUE #5639] Deprecated the ambiguous methods of lite pull consumer Dec 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5640 (3b4fcda) into develop (fac3112) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             develop    #5640      +/-   ##
=============================================
- Coverage      42.41%   42.35%   -0.06%     
+ Complexity      7968     7957      -11     
=============================================
  Files           1023     1023              
  Lines          71475    71479       +4     
  Branches        9444     9444              
=============================================
- Hits           30314    30275      -39     
- Misses         37317    37358      +41     
- Partials        3844     3846       +2     
Impacted Files Coverage Δ
...ketmq/client/consumer/DefaultLitePullConsumer.java 75.70% <50.00%> (-1.76%) ⬇️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...controller/impl/DefaultBrokerHeartbeatManager.java 74.41% <0.00%> (-3.49%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-2.99%) ⬇️
...e/rocketmq/store/ha/autoswitch/EpochFileCache.java 78.47% <0.00%> (-2.78%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 46.60% <0.00%> (-2.27%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.00% <0.00%> (-2.17%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui merged commit e5fadc7 into apache:develop Dec 4, 2022
lizhimins pushed a commit to lizhimins/rocketmq that referenced this pull request Dec 5, 2022
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commitSync method is ambiguous in lite pull consumer
5 participants