Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #5660] optimize LagCalculationIT #5661

Merged
merged 1 commit into from
Dec 9, 2022
Merged

[ISSUE #5660] optimize LagCalculationIT #5661

merged 1 commit into from
Dec 9, 2022

Conversation

ShadowySpirits
Copy link
Member

fix #5660

@ShadowySpirits ShadowySpirits marked this pull request as ready for review December 7, 2022 07:32
@ShadowySpirits
Copy link
Member Author

@lizhimins @Oliverwqcwrw Can you rerun the macOS test? It seems to be failed because of another flaky test.

@Oliverwqcwrw
Copy link
Member

@lizhimins @Oliverwqcwrw Can you rerun the macOS test? It seems to be failed because of another flaky test.

done

drpmma
drpmma approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 774bc67 into apache:develop Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpmma drpmma drpmma approved these changes

@tsunghanjacktsai tsunghanjacktsai tsunghanjacktsai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize LagCalculationIT
4 participants
@ShadowySpirits @Oliverwqcwrw @drpmma @tsunghanjacktsai