Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5659] Remove redundant error log output #5662

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #5659

Brief changelog

Since printStackTrace() is also an err stream output, duplicate log prints are removed

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5662 (29bc334) into develop (d5e6fb6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5662      +/-   ##
=============================================
- Coverage      42.44%   42.41%   -0.04%     
+ Complexity      7992     7982      -10     
=============================================
  Files           1023     1023              
  Lines          71552    71551       -1     
  Branches        9455     9455              
=============================================
- Hits           30372    30345      -27     
- Misses         37327    37349      +22     
- Partials        3853     3857       +4     
Impacted Files Coverage Δ
...n/java/org/apache/rocketmq/proxy/ProxyStartup.java 45.13% <ø> (+0.39%) ⬆️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (-5.65%) ⬇️
...e/rocketmq/store/ha/autoswitch/EpochFileCache.java 77.08% <0.00%> (-4.17%) ⬇️
...tmq/remoting/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 46.60% <0.00%> (-2.27%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 73.11% <0.00%> (-2.16%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 59.73% <0.00%> (-1.77%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins lizhimins merged commit 7a68fca into apache:develop Dec 7, 2022
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant error log output
4 participants