Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5651]Fix unable to send messages normally due to HA disconnection #5667

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Dec 8, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #5651

Brief changelog

  • Fix unable to send messages normally due to HA disconnection

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@mxsm
Copy link
Member Author

mxsm commented Dec 8, 2022

@RongtongJin @hzh0425 PTAL~

@RongtongJin RongtongJin merged commit aa02160 into apache:develop Dec 9, 2022
@mxsm mxsm deleted the rocketmq-5651 branch December 9, 2022 03:27
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
RongtongJin pushed a commit to RongtongJin/rocketmq that referenced this pull request Jan 10, 2023
@RongtongJin RongtongJin added the module/ha high availably related label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send messages normally due to HA disconnection
2 participants