Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5699] remove duplicate code definition of UtilAll.isBlank #5700

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

xiaoyifang
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #5699

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@xiaoyifang xiaoyifang force-pushed the fix/issue-5699 branch 2 times, most recently from 4fd1235 to 1193389 Compare December 15, 2022 08:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #5700 (bca7de3) into develop (aa7a442) will increase coverage by 0.18%.
The diff coverage is 50.00%.

❗ Current head bca7de3 differs from pull request most recent head 959bdf3. Consider uploading reports for the commit 959bdf3 to get more accurate results

@@              Coverage Diff              @@
##             develop    #5700      +/-   ##
=============================================
+ Coverage      42.35%   42.53%   +0.18%     
- Complexity      8192     8210      +18     
=============================================
  Files           1060     1060              
  Lines          73108    73091      -17     
  Branches        9586     9580       -6     
=============================================
+ Hits           30962    31092     +130     
+ Misses         38234    38083     -151     
- Partials        3912     3916       +4     
Impacted Files Coverage Δ
...he/rocketmq/remoting/protocol/RemotingCommand.java 70.83% <0.00%> (+1.10%) ⬆️
...cketmq/remoting/protocol/RocketMQSerializable.java 84.34% <ø> (-0.78%) ⬇️
.../main/java/org/apache/rocketmq/common/UtilAll.java 36.52% <100.00%> (-0.55%) ⬇️
...tmq/remoting/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...controller/impl/DefaultBrokerHeartbeatManager.java 74.41% <0.00%> (-3.49%) ⬇️
...che/rocketmq/container/BrokerContainerStartup.java 53.94% <0.00%> (-2.20%) ⬇️
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 65.30% <0.00%> (-2.05%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@lizhanhui lizhanhui merged commit e986534 into apache:develop Dec 29, 2022
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
…nk (apache#5700)

* [ISSUE apache#5699] remove duplicate code definition of UtilAll.isBlank

* [ISSUE apache#5699] remove duplicate code definition of UtilAll.isBlank
drpmma pushed a commit that referenced this pull request Feb 21, 2023
)

* [ISSUE #5699] remove duplicate code definition of UtilAll.isBlank

* [ISSUE #5699] remove duplicate code definition of UtilAll.isBlank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code issue]duplicate code of UtilAll.isBlank method
6 participants