[ISSUE #5754] [RIP-57] Add asynchronous interfaces to MessageStore #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdkxlk
reviewed
Dec 22, 2022
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
Outdated
Show resolved
Hide resolved
lizhimins
reviewed
Dec 22, 2022
broker/src/main/java/org/apache/rocketmq/broker/processor/DefaultPullMessageResultHandler.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/org/apache/rocketmq/broker/failover/EscapeBridge.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
Outdated
Show resolved
Hide resolved
aaron-ai
reviewed
Dec 22, 2022
broker/src/main/java/org/apache/rocketmq/broker/failover/EscapeBridge.java
Outdated
Show resolved
Hide resolved
aaron-ai
reviewed
Dec 22, 2022
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
Outdated
Show resolved
Hide resolved
aaron-ai
reviewed
Dec 22, 2022
ShadowySpirits
force-pushed
the
tiered_storage_async_api
branch
from
67ca3b7
to
562fab8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5755 +/- ##
=============================================
- Coverage 42.45% 42.41% -0.04%
- Complexity 8215 8227 +12
=============================================
Files 1060 1060
Lines 73193 73363 +170
Branches 9598 9601 +3
=============================================
+ Hits 31071 31119 +48
- Misses 38221 38325 +104
- Partials 3901 3919 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ShadowySpirits
force-pushed
the
tiered_storage_async_api
branch
from
23d186f
to
17335e3
Compare
zhouxinyu
previously approved these changes
Dec 25, 2022
aaron-ai
previously approved these changes
Dec 25, 2022
lizhimins
previously approved these changes
Dec 26, 2022
ShadowySpirits
dismissed stale reviews from lizhimins, aaron-ai, and zhouxinyu
via
b027995
ShadowySpirits
force-pushed
the
tiered_storage_async_api
branch
from
17335e3
to
b027995
Compare
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
aaron-ai
approved these changes
Dec 29, 2022
Langkeren
pushed a commit
to Langkeren/rocketmq
that referenced
this pull request
Jan 3, 2023
…ore (apache#5755) * [RIP-57] Add asynchronous interfaces to MessageStore * fix unit test * Modified according to review comments * Remove unnecessary stubbing * Add some other methods to MessageStore * fix bazel test * Skip failing test case Signed-off-by: Li Zhanhui <lizhanhui@gmail.com> Signed-off-by: Li Zhanhui <lizhanhui@gmail.com> Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
…5755) * [RIP-57] Add asynchronous interfaces to MessageStore * fix unit test * Modified according to review comments * Remove unnecessary stubbing * Add some other methods to MessageStore * fix bazel test * Skip failing test case Signed-off-by: Li Zhanhui <lizhanhui@gmail.com> Signed-off-by: Li Zhanhui <lizhanhui@gmail.com> Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to #5754