Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5793]Translation QuorumACK.md chinese document to english document and polish cn document #5794

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Dec 30, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5793

Brief changelog

  • Translation QuorumACK.md chinese document to english document
  • polish QuorumACK.md cn document

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #5794 (c416ae6) into develop (b95f69a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5794      +/-   ##
=============================================
- Coverage      42.42%   42.37%   -0.06%     
+ Complexity      8217     8213       -4     
=============================================
  Files           1060     1060              
  Lines          73354    73354              
  Branches        9598     9598              
=============================================
- Hits           31123    31081      -42     
- Misses         38312    38353      +41     
- Partials        3919     3920       +1     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 43.29% <0.00%> (-3.43%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 83.17% <0.00%> (-1.45%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 39.62% <0.00%> (-1.35%) ⬇️
...apache/rocketmq/store/queue/BatchConsumeQueue.java 69.67% <0.00%> (-0.55%) ⬇️
...he/rocketmq/controller/impl/DLedgerController.java 65.96% <0.00%> (-0.53%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 65.20% <0.00%> (-0.11%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 34.53% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 8d65abf into apache:develop Dec 31, 2022
@mxsm mxsm deleted the rocketmq-5793 branch December 31, 2022 12:07
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
…sh document and polish cn document (apache#5794)

* [ISSUE apache#5793]Translation QuorumACK.md chinese document to english document and polish cn document

* polish cn document
drpmma pushed a commit that referenced this pull request Feb 21, 2023
…ument and polish cn document (#5794)

* [ISSUE #5793]Translation QuorumACK.md chinese document to english document and polish cn document

* polish cn document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation QuorumACK.md chinese document to english document and polish cn document
3 participants