Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #5823] Add delete topic in message store interface #5824

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[ISSUE #5823] Add delete topic in message store interface #5824

merged 1 commit into from
Jan 5, 2023

Conversation

lizhimins
Copy link
Member

No description provided.

RongtongJin
RongtongJin reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have deleteTopics and cleanUnusedTopic API, I don't think there is anything wrong with the semantics of cleanUnusedTopic. Or we can use deleteTopic instead of cleanUnusedTopic in message store.

@lizhimins
Copy link
Member Author

lizhimins commented Jan 5, 2023 •
edited

RocketMQ has "clean unused topic" and "delete topic" in remoting API，only "clean unused topic" in store API

@RongtongJin
Copy link
Contributor

image

"delete topic" is a remoting API，"clean unused topic" is a store API

“clean unused topic” is also a remoting API, but it has different meanings from the store API "clean unused topic", so why not rename store API "clean unused topic" to "delete topics" ?

@lizhimins lizhimins changed the title [ISSUE #5823] Fix clean unused topic semantic error in default message store [ISSUE #5823] Add delete topic in message store interface Jan 5, 2023
@lizhimins lizhimins merged commit 83c47dd into apache:develop Jan 5, 2023
drpmma pushed a commit that referenced this pull request Feb 21, 2023
@lizhimins @drpmma
[ISSUE #5823] Add delete topic in message store interface (#5824)
d79a7c6 
Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RongtongJin RongtongJin RongtongJin left review comments

@aaron-ai aaron-ai aaron-ai approved these changes

@ShadowySpirits ShadowySpirits ShadowySpirits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lizhimins @RongtongJin @aaron-ai @ShadowySpirits