Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5830] fix bug in GetMessageResult#getMessageCount #5831

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

ShadowySpirits
Copy link
Member

fix #5830

@codecov-commenter
Copy link

Codecov Report

Merging #5831 (397c23a) into develop (9b3b551) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #5831      +/-   ##
=============================================
- Coverage      42.45%   42.42%   -0.04%     
  Complexity      8230     8230              
=============================================
  Files           1060     1060              
  Lines          73414    73416       +2     
  Branches        9606     9606              
=============================================
- Hits           31171    31148      -23     
- Misses         38319    38345      +26     
+ Partials        3924     3923       -1     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/store/GetMessageResult.java 87.67% <100.00%> (+10.20%) ⬆️
...controller/impl/DefaultBrokerHeartbeatManager.java 82.27% <0.00%> (-3.80%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 43.29% <0.00%> (-3.43%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-2.41%) ⬇️
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 65.30% <0.00%> (-2.05%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 39.62% <0.00%> (-1.35%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 33.97% <0.00%> (-1.11%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.22% <0.00%> (-0.54%) ⬇️
...ava/org/apache/rocketmq/store/MappedFileQueue.java 62.25% <0.00%> (-0.50%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.17% <0.00%> (-0.25%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShadowySpirits ShadowySpirits marked this pull request as ready for review January 6, 2023 02:00
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 268e9b9 into apache:develop Jan 6, 2023
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* fix bug in GetMessageResult#getMessageCount

* add license

* fix codestyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in GetMessageResult#getMessageCount
3 participants