Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5852] Don't create PlainAccessValidator when enable proxy and aclEnable is false #5854

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #5852

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5854 (5b86802) into develop (5894332) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5854      +/-   ##
=============================================
- Coverage      42.48%   42.42%   -0.06%     
+ Complexity      8248     8237      -11     
=============================================
  Files           1060     1060              
  Lines          73473    73472       -1     
  Branches        9616     9616              
=============================================
- Hits           31215    31171      -44     
- Misses         38334    38369      +35     
- Partials        3924     3932       +8     
Impacted Files Coverage Δ
...g/apache/rocketmq/srvutil/AclFileWatchService.java 0.00% <ø> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-11.95%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (-5.65%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-4.17%) ⬇️
...tmq/remoting/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 69.29% <0.00%> (-3.51%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-2.41%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oliverwqcwrw Oliverwqcwrw changed the title [ISSUE #5852] Remove acl dir not exist log [ISSUE #5852] Don't create PlainAccessValidator when enable proxy and aclEnable is false Jan 10, 2023
@Oliverwqcwrw Oliverwqcwrw merged commit 3291934 into apache:develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The AclWatchService still start when enable proxy and enableAcl is false
4 participants