Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5876] fix resource leak in DefaultLitePullConsumerTest #5877

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

ShadowySpirits
Copy link
Member

fix #5876

@codecov-commenter
Copy link

Codecov Report

Merging #5877 (89d30a5) into develop (cbad53d) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5877      +/-   ##
=============================================
- Coverage      42.45%   42.36%   -0.09%     
+ Complexity      8283     8263      -20     
=============================================
  Files           1066     1066              
  Lines          73670    73670              
  Branches        9629     9629              
=============================================
- Hits           31276    31213      -63     
- Misses         38445    38505      +60     
- Partials        3949     3952       +3     
Impacted Files Coverage Δ
...tools/command/namesrv/WipeWritePermSubCommand.java 50.00% <0.00%> (-19.24%) ⬇️
...n/java/org/apache/rocketmq/test/util/StatUtil.java 15.49% <0.00%> (-14.09%) ⬇️
...e/rocketmq/store/ha/autoswitch/EpochFileCache.java 77.08% <0.00%> (-4.17%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 32.09% <0.00%> (-3.09%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 49.23% <0.00%> (-3.08%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...rg/apache/rocketmq/remoting/netty/NettyLogger.java 13.60% <0.00%> (-1.37%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.75% <0.00%> (-1.25%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ni-ze ni-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch~

@RongtongJin RongtongJin merged commit 46869c9 into apache:develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix resource leak in DefaultLitePullConsumerTest
5 participants