[ISSUE #5684] request code should be short, to support serializeTypeCurrentRPC=ROCKETMQ #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Jan 20, 2023
remoting/src/test/java/org/apache/rocketmq/remoting/protocol/RequestCodeTest.java
Outdated
Show resolved
Hide resolved
|
Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java:368:2: 'method def rcurly' has incorrect indentation level 1, expected level should be 4. [Indentation] |
Codecov Report
@@ Coverage Diff @@
## develop #5909 +/- ##
==========================================
Coverage 43.37% 43.37%
Complexity 8809 8809
==========================================
Files 1090 1090
Lines 76412 76409 -3
Branches 9981 9981
==========================================
+ Hits 33145 33146 +1
- Misses 39118 39128 +10
+ Partials 4149 4135 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HScarb
previously approved these changes
Feb 3, 2023
echooymxq
reviewed
Mar 15, 2023
There was a problem hiding this comment.
@yuz10 @RongtongJin I also encountered this problem, but i don't recommend doing it through such an indirect way.
I perfer to redefine the compatible code directly.
such as:
public static final int POP_MESSAGE = 200050;
public static final int _POP_MESSAGE = 3442;
public static final int ACK_MESSAGE = 200051;
public static final int _ACK_MESSAGE = 3443;
...
3 tasks
3 tasks
|
@RongtongJin @echooymxq @HScarb Please review the code again. |
…eTypeCurrentRPC=ROCKETMQ fix code style detect occupied request code
HScarb
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
#5684
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.