[ISSUE #5918]Fix MessageStoreConfig some typo #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5919 +/- ##
=============================================
- Coverage 43.13% 43.08% -0.06%
+ Complexity 9005 8986 -19
=============================================
Files 1107 1107
Lines 78297 78297
Branches 10204 10204
=============================================
- Hits 33776 33733 -43
- Misses 40302 40341 +39
- Partials 4219 4223 +4
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oliverwqcwrw
requested changes
Jan 28, 2023
| } | ||
|
|
||
| public void setWarmMapedFileEnable(boolean warmMapedFileEnable) { | ||
| this.warmMapedFileEnable = warmMapedFileEnable; | ||
| public void setWarmMappedFileEnable(boolean warmMapedFileEnable) { |
There was a problem hiding this comment.
Suggested change
| public void setWarmMappedFileEnable(boolean warmMapedFileEnable) { | |
| public void setWarmMappedFileEnable(boolean warmMappedFileEnable) { |
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
Outdated
Show resolved
Hide resolved
|
@Oliverwqcwrw PLS check |
Oliverwqcwrw
previously approved these changes
Jan 28, 2023
HScarb
reviewed
Feb 1, 2023
| @@ -81,8 +80,8 @@ public class MessageStoreConfig { | |||
| /** | |||
| * 1. Register to broker after (startTime + disappearTimeAfterStart) | |||
| * 2. Internal msg exchange will start after (startTime + disappearTimeAfterStart) | |||
| * A. PopReviveService | |||
There was a problem hiding this comment.
No need to modify indentation here
There was a problem hiding this comment.
No need to modify indentation here
This is caused by tool formatting， I will fix it and resubmit later
mxsm
requested review from
Oliverwqcwrw and
HScarb
and removed request for
Oliverwqcwrw
|
Hi @HScarb PTAL~ |
HScarb
previously approved these changes
Apr 23, 2023
caigy
requested changes
Apr 24, 2023
| @@ -275,7 +274,7 @@ public class MessageStoreConfig { | |||
| private int commitLogSwapMapReserveFileNum = 100; | |||
| private long logicQueueForceSwapMapInterval = 12L * 60 * 60 * 1000; | |||
| private long logicQueueSwapMapInterval = 1L * 60 * 60 * 1000; | |||
| private long cleanSwapedMapInterval = 5L * 60 * 1000; | |||
| private long cleanSwappedMapInterval = 5L * 60 * 1000; | |||
There was a problem hiding this comment.
These modifications are incompatible thus should be avoided.
|
@caigy PTAL~ thanks |
Oliverwqcwrw
reviewed
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
close #5918
close #5882
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.