[ISSUE #5921] Support domain resolution to obtain the controller address #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsm
reviewed
Jan 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #5922 +/- ##
=============================================
+ Coverage 43.36% 43.38% +0.01%
- Complexity 8810 8815 +5
=============================================
Files 1090 1090
Lines 76407 76416 +9
Branches 9981 9982 +1
=============================================
+ Hits 33135 33150 +15
+ Misses 39126 39120 -6
Partials 4146 4146
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
done |
Oliverwqcwrw
requested changes
Jan 25, 2023
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java
Outdated
Show resolved
Hide resolved
mxsm
approved these changes
Jan 25, 2023
caigy
approved these changes
Jan 25, 2023
|
Hi @Oliverwqcwrw, I have fixed the typo error, Plz check again. |
Oliverwqcwrw
approved these changes
Jan 25, 2023
RongtongJin
added a commit
to RongtongJin/rocketmq
that referenced
this pull request
Jan 28, 2023
MatrixHB
pushed a commit
that referenced
this pull request
Jan 30, 2023
…frequently causing thread blocking when the network partition (#5930) * Fix the issue that broker send heartbeat to controller frequently causing thread blocking when the network partition * Fix the ReplicasManagerTest can not pass * Reslove conflict with #5922 * Fix code style * Rename isAddressCanConnect to isAddressReachable * Rename isAddressCanConnect to isAddressReachable
RongtongJin
added a commit
to RongtongJin/rocketmq
that referenced
this pull request
Jan 30, 2023
…r address (apache#5922) * Support domain resolution to obtain the controller address * Remove useless import * Fix testLookupAddressByDomain can not pass * Fix typo error
RongtongJin
added a commit
to RongtongJin/rocketmq
that referenced
this pull request
Jan 30, 2023
…oller frequently causing thread blocking when the network partition (apache#5930) * Fix the issue that broker send heartbeat to controller frequently causing thread blocking when the network partition * Fix the ReplicasManagerTest can not pass * Reslove conflict with apache#5922 * Fix code style * Rename isAddressCanConnect to isAddressReachable * Rename isAddressCanConnect to isAddressReachable
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
…ess (#5922) * Support domain resolution to obtain the controller address * Remove useless import * Fix testLookupAddressByDomain can not pass * Fix typo error
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
…frequently causing thread blocking when the network partition (#5930) * Fix the issue that broker send heartbeat to controller frequently causing thread blocking when the network partition * Fix the ReplicasManagerTest can not pass * Reslove conflict with #5922 * Fix code style * Rename isAddressCanConnect to isAddressReachable * Rename isAddressCanConnect to isAddressReachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
Close #5921
Support domain resolution to obtain the controller address
Brief changelog
Support domain resolution to obtain the controller address
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.