Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5927]Add Proxy deploy guide cn document #5928

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Jan 26, 2023

Make sure set the target branch to develop

What is the purpose of the change

close #5927

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5928 (4a871bc) into develop (a961a9b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5928      +/-   ##
=============================================
- Coverage      43.36%   43.34%   -0.03%     
+ Complexity      8810     8803       -7     
=============================================
  Files           1090     1090              
  Lines          76407    76407              
  Branches        9981     9981              
=============================================
- Hits           33135    33116      -19     
- Misses         39126    39147      +21     
+ Partials        4146     4144       -2     
Impacted Files Coverage Δ
.../apache/rocketmq/store/ha/io/AbstractHAReader.java 79.31% <0.00%> (-10.35%) ⬇️
...ocketmq/tieredstore/container/TieredIndexFile.java 68.10% <0.00%> (-3.88%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 58.46% <0.00%> (-3.08%) ⬇️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 74.00% <0.00%> (-2.53%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-2.41%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.59% <0.00%> (-0.63%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 36.52% <0.00%> (-0.46%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.17% <0.00%> (-0.25%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 65.03% <0.00%> (-0.11%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems redundant to maintain documents here and in official sites, what if just refer corresponding sections in official sites?

@mxsm
Copy link
Member Author

mxsm commented Jan 27, 2023

It seems redundant to maintain documents here and in official sites, what if just refer corresponding sections in official sites?

@caigy
The official website's documentation is more detailed and there should be corresponding Chinese documentation in the project's documentation as well. As for whether maintenance of documentation is needed in both the official website and the project, my personal opinion is that the community should discuss it. In the past, many design documents were maintained in the project. The official website's documentation, IMO, is more geared towards user guides and some basic concepts. At the same time, the official website maintains documentation for multiple projects in the RocketMQ ecosystem. So, in my personal opinion, it is still necessary to maintain the documentation in the MQ project.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit c8e22a6 into apache:develop Feb 14, 2023
@mxsm mxsm deleted the rocketmq-5927 branch February 14, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proxy deploy guide cn document
4 participants