Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5953] calculate retry message throughput in pop consumption mode #5954

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

ShadowySpirits
Copy link
Member

close #5953

@ShadowySpirits ShadowySpirits marked this pull request as ready for review January 30, 2023 09:39
@codecov-commenter
Copy link

Codecov Report

Merging #5954 (888d048) into develop (a961a9b) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

@@              Coverage Diff              @@
##             develop    #5954      +/-   ##
=============================================
- Coverage      43.36%   43.34%   -0.03%     
+ Complexity      8810     8799      -11     
=============================================
  Files           1090     1090              
  Lines          76407    76467      +60     
  Branches        9981     9992      +11     
=============================================
+ Hits           33135    33143       +8     
- Misses         39126    39173      +47     
- Partials        4146     4151       +5     
Impacted Files Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 37.13% <87.50%> (+0.15%) ⬆️
...q/namesrv/routeinfo/BrokerHousekeepingService.java 70.00% <0.00%> (-10.00%) ⬇️
...controller/impl/DefaultBrokerHeartbeatManager.java 82.27% <0.00%> (-3.80%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 58.97% <0.00%> (-2.57%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-2.41%) ⬇️
...va/org/apache/rocketmq/store/util/PerfCounter.java 64.39% <0.00%> (-2.10%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 40.94% <0.00%> (-1.12%) ⬇️
...q/controller/impl/manager/ReplicasInfoManager.java 61.07% <0.00%> (-0.89%) ⬇️
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@lizhimins lizhimins merged commit e2a341e into apache:develop Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RIP-46] calculate retry message throughput in pop consumption mode
6 participants