Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #608] Polish filter example #620

Merged
merged 1 commit into from
Jan 24, 2019
Merged

[ISSUE #608] Polish filter example #620

merged 1 commit into from
Jan 24, 2019

Conversation

RongtongJin
Copy link
Contributor

What is the purpose of the change

Fix issue608
Polish filter example

Brief changelog

  • filter
    • SqlFilterConsumer.java (renamed from SqlConsumer.java, fix bug: missing “and” in SQL statement, add code comments )
    • SqlFilterProducer.java (renamed from SqlProducer.java, optimize code quality)
    • TagFilterConsumer.java (renamed from Consumer.java, changed from filtersrv example to tag filter example)
    • TagFilterProducer.java (renamed from Producer.java, changed from filtersrv example to tag filter example)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 43.082% when pulling e204376 on RongtongJin:polish_filter_example into 385c695 on apache:develop.

@duhenglucky duhenglucky added this to the 4.4.1 milestone Jan 24, 2019
@duhenglucky
Copy link
Contributor

LGTM~

@duhenglucky duhenglucky merged commit 11f6edd into apache:develop Jan 24, 2019
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
@duhenglucky
Merge pull request apache#620 from RongtongJin/polish_filter_example
afed0de 
[ISSUE apache#608] Polish filter example
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
@duhenglucky
Merge pull request apache#620 from RongtongJin/polish_filter_example
9ba3951 
[ISSUE apache#608] Polish filter example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/bug type/enhancement
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RongtongJin @coveralls @duhenglucky